-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite for py-tree-sitter 0.22 #65
base: main
Are you sure you want to change the base?
Conversation
The user-facing API has not changed. However, languages that have their own packages were removed, and packages for 32bit archs will not be built (unless requested).
Hi @ObserverOfTime great work. Can you please elaborate how do you decide which languages make the cut and which don't ? As I understand, different developers will have different requirements. Also, I understand maintaining so many languages would be impractical, but shouldn't then there be a way to help a developer install additional language support at runtime (post installation of package via pip) and not have to go via PR and build process to get that language support ? Maybe it can be achieved via documentation highlighting detailed steps. |
You can add any grammar you want here (see CONTRIBUTING.md for the process) but I chose not to add those that have been updated upstream and can be installed from pypi or git. You can also submit a PR to grammars that have not been updated:
|
Is there a plan to merge and release this PR? As it stands, the package isn't usable with latest versions until this is fixed |
@ObserverOfTime are you willing to release your own package instead of this one? |
No. |
Ok, thank you @ObserverOfTime - I will fork your PR and publish the package, after some adjustments. |
i really like what you did in the PR, so i am using most of it (i will give due credit in the readme for sure!). I am going in a different direction though - i am creating a giant language pack for tree sitter. First python, but it can also have other bindings. Its the use case I have - I need to parse all sorts of code types and chunk them for AI processing, currently in python. |
why leave this PR hanging? the code cannot be built anymore as-is today.. or at least take in #71... |
This PR rewrites the project to make it work with py-tree-sitter 0.22.
Fixes #55, closes #60, fixes #61, fixes #63, fixes #64, fixes #67
Don't take this to mean I will be maintaining this project going forward.
If @grantjenks is still unable to maintain it and doesn't want to give it to some random person,
then someone can fork it, pull my changes, rename the package, and maintain the fork.
But don't try to package all ~400 languages. Just some popular ones that don't yet have a package.