Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Fix error location reporting of unbound modules and labels #1577

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix(compiler): Fix error location reporting of unbound modules and labels #1577

merged 1 commit into from
Jan 5, 2023

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Jan 5, 2023

This reports the errors inline instead of at the top of the file, like so:

image

image

@ospencer ospencer requested a review from peblair as a code owner January 5, 2023 17:43
@ospencer ospencer self-assigned this Jan 5, 2023
@ospencer ospencer requested a review from phated as a code owner January 5, 2023 17:43
phated
phated approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

marcusroberts
marcusroberts approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ospencer ospencer merged commit 5146b14 into main Jan 5, 2023
@ospencer ospencer deleted the oscar/fix-error-reporting-locs branch January 5, 2023 23:30
@github-actions github-actions bot mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@marcusroberts marcusroberts marcusroberts approved these changes

@peblair peblair Awaiting requested review from peblair peblair is a code owner

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ospencer @phated @marcusroberts