Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: Excessive stack depth comparing types #1304

Open
ericwilhite opened this issue Jan 6, 2025 · 5 comments · Fixed by #1307
Open

Typescript: Excessive stack depth comparing types #1304

ericwilhite opened this issue Jan 6, 2025 · 5 comments · Fixed by #1307

Comments

@ericwilhite
Copy link

Screenshot

image

image

image

Description

The generated client causes Typescript to complain of "Excessive stack depth comparing types".

I get the error when trying to return even the simplest of our objects.

Our schema is large and very relational, but not huge.

Reproduction Steps/Repo Link

-- I cannot share our SDL but I'm imagining generating a Document Builder client with a large/complex schema will recreate this.

@jasonkuhrt
Copy link
Member

Thanks for reporting this @ericwilhite. Maybe I can reproduce this by generating client against the GitHub API.

I will prioritize trying to fix this since this kind of bug makes Graffle document-builder unusable :(

@jasonkuhrt jasonkuhrt pinned this issue Jan 6, 2025
@jasonkuhrt
Copy link
Member

I am able to reproduce with the GitHub API. I'll try to look more into it in the coming week.

@jasonkuhrt
Copy link
Member

jasonkuhrt commented Jan 12, 2025

I'll need a few more iterations to get this in a better state but I've now got a client for the GH api in the test suite which is passing type checking. Let me know if you find any more issues.

@lern905
Copy link

lern905 commented Feb 28, 2025

Hello @jasonkuhrt, I didn't want to open a new ticket given that this is related.

I've tried building a client for the shopify admin client (endpoint https://shopify.dev/admin-graphql-direct-proxy/2025-01) and I'm getting the same error when trying to autocomplete.

Not sure if it's something on my side. Granted, it's a pretty big schema.

Thank you!

@jasonkuhrt
Copy link
Member

@lern905 Thanks for letting me know! I was able to get the GH API working which was bigger. I will re-open this to investigate the Shoppify API.

@jasonkuhrt jasonkuhrt reopened this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants