-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript: Excessive stack depth comparing types #1304
Comments
Thanks for reporting this @ericwilhite. Maybe I can reproduce this by generating client against the GitHub API. I will prioritize trying to fix this since this kind of bug makes Graffle document-builder unusable :( |
I am able to reproduce with the GitHub API. I'll try to look more into it in the coming week. |
I'll need a few more iterations to get this in a better state but I've now got a client for the GH api in the test suite which is passing type checking. Let me know if you find any more issues. |
Hello @jasonkuhrt, I didn't want to open a new ticket given that this is related. I've tried building a client for the shopify admin client (endpoint Not sure if it's something on my side. Granted, it's a pretty big schema. Thank you! |
@lern905 Thanks for letting me know! I was able to get the GH API working which was bigger. I will re-open this to investigate the Shoppify API. |
Screenshot
Description
The generated client causes Typescript to complain of "Excessive stack depth comparing types".
I get the error when trying to return even the simplest of our objects.
Our schema is large and very relational, but not huge.
Reproduction Steps/Repo Link
-- I cannot share our SDL but I'm imagining generating a Document Builder client with a large/complex schema will recreate this.
The text was updated successfully, but these errors were encountered: