This repository has been archived by the owner on May 21, 2024. It is now read-only.
Support for the google wrappers #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
olegbespalov
force-pushed
the
fix/wrappers
branch
from
05a4176 to
210fa34
Compare
olegbespalov
changed the title
olegbespalov
requested review from
oleiade,
codebien and
mstoykov
and removed request for
a team and
oleiade
olegbespalov
changed the title
mstoykov
reviewed
Sep 7, 2023
mstoykov
reviewed
Sep 8, 2023
mstoykov
approved these changes
Sep 8, 2023
|
LGTM otherwise then us having what seems like hte same code in two places |
mstoykov
approved these changes
Sep 11, 2023
codebien
reviewed
Sep 11, 2023
olegbespalov
force-pushed
the
fix/wrappers
branch
from
e45a5d7 to
8a02043
Compare
olegbespalov
commented
Sep 11, 2023
mstoykov
approved these changes
Sep 11, 2023
codebien
approved these changes
Sep 11, 2023
olegbespalov
force-pushed
the
fix/wrappers
branch
from
95d65e7 to
d99c9bf
Compare
|
For the record, I just rebased and squashed some commits, going to merge |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change allows the use of the Google Protobuff wrappers and brings the tests for that functionality.
Why?
Initially reported in grafana/k6#3232 and attempted to fix in grafana/k6#3238