Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Page.evaluate for async migration #1343

Merged
merged 3 commits into from
May 23, 2024
Merged

Prepare Page.evaluate for async migration #1343

merged 3 commits into from
May 23, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented May 23, 2024 •
edited
Loading

What?

Turns panics into errors only for evaluate as Page is big. So, I wanted to make the review process straightforward by sending this PR first.

Why?

To make the async migration more reliable.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#1307

@inancgumus inancgumus self-assigned this May 23, 2024
@inancgumus inancgumus added async supports async (promises) refactor mapping k6 browser to Goja mapping related. stability runtime stability improvements and removed async supports async (promises) labels May 23, 2024
@inancgumus inancgumus marked this pull request as ready for review May 23, 2024 09:38
@inancgumus inancgumus requested a review from ankur22 May 23, 2024 09:38
@inancgumus inancgumus mentioned this pull request May 23, 2024
Closed
ankur22
ankur22 approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thanks!

@inancgumus inancgumus merged commit 7ca6b73 into main-async May 23, 2024
14 checks passed
@inancgumus inancgumus deleted the async/page-prepare-evaluate branch May 23, 2024 10:12
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
mapping k6 browser to Goja mapping related. refactor stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22