Prepare ElementHandle for async migration
#1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
added
refactor
mapping
inancgumus
force-pushed
the
async/elementhandle-prepare
branch
from
b2a362a to
8a72a89
Compare
Although ElementHandle.BoundingBox always returns a nil error (as PW does), for consistency, it's better to reflect this in the API test here.
It's not related to this PR, but I wanted to tackle them here for convenience. Apologies for the inconvinience.
No need to apply slow motion for querying actions.
inancgumus
force-pushed
the
async/elementhandle-prepare
branch
from
8a72a89 to
5c968cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Turns panics into errors and reorders the methods for consistency.
Why?
To make the async migration more reliable.
Checklist
Related PR(s)/Issue(s)
#1296