Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Keyboard for async migration #1313

Merged
merged 6 commits into from
May 8, 2024
Merged

Prepare Keyboard for async migration #1313

merged 6 commits into from
May 8, 2024

Conversation

inancgumus
Copy link
Member

What?

Maps the forgotten Keyboard, adds a test, and turns panics into errors.

Why?

To make the async migration.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#1304

@inancgumus inancgumus self-assigned this May 8, 2024
@inancgumus inancgumus mentioned this pull request May 8, 2024
Closed
@inancgumus inancgumus force-pushed the async/keyboard-prepare branch from e6234c1 to 35e42a9 Compare May 8, 2024 09:48
@inancgumus inancgumus marked this pull request as ready for review May 8, 2024 09:52
@inancgumus inancgumus requested a review from ankur22 May 8, 2024 09:53
@inancgumus inancgumus added mapping k6 browser to Goja mapping related. stability runtime stability improvements labels May 8, 2024
@inancgumus inancgumus force-pushed the async/keyboard-prepare branch from 35e42a9 to ce59afd Compare May 8, 2024 09:56
ankur22
ankur22 approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this refactor 🙏 LGTM

@inancgumus inancgumus force-pushed the async/browser-newpage branch from 6a95862 to da14067 Compare May 8, 2024 10:19
Base automatically changed from async/browser-newpage to main-async May 8, 2024 10:28
@inancgumus inancgumus force-pushed the async/keyboard-prepare branch from ce59afd to 5132a18 Compare May 8, 2024 10:29
@inancgumus inancgumus merged commit 644fcef into main-async May 8, 2024
14 checks passed
@inancgumus inancgumus deleted the async/keyboard-prepare branch May 8, 2024 10:43
@inancgumus inancgumus changed the title Prepare Keyboard for Async migration Prepare Keyboard for async migration May 9, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
mapping k6 browser to Goja mapping related. refactor stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22