Override OTEL tracer Start() method to include metadata #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ka3de
requested review from
inancgumus and
ankur22
and removed request for
inancgumus and
ankur22
ankur22
approved these changes
Jan 8, 2024
Modifies our tracer implementation to override the underlying OTEL's tracer Start() method so the extra traces metadata set by the K6_BROWSER_TRACES_METADATA environment variable is also including when using the Start() method directly. Currently the Start() method is only used when creating the root span for each iteration.
ka3de
force-pushed
the
fix/traces-metadata-rootspan
branch
from
42258cb to
72beeed
Compare
inancgumus
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Modifies our tracer implementation to override and wrap the underlying OTEL tracer's
Start()method so the extra traces metadata set by theK6_BROWSER_TRACES_METADATAenvironment variable are also including when using the OTEL tracer'sStart()method directly.Why?
Fixes an issue for which the extra metadata set through
K6_BROWSER_TRACES_METADATAwas not included in the iteration root span.Checklist
Related PR(s)/Issue(s)
#1104