Add support for traces metadata #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ka3de
force-pushed
the
feat/traces-metadata
branch
from
b1c5d34 to
9658d79
Compare
ka3de
force-pushed
the
feat/tracing
branch
3 times, most recently
from
f4cdfc8 to
0f0e214
Compare
ka3de
force-pushed
the
feat/traces-metadata
branch
from
9658d79 to
44de994
Compare
ka3de
force-pushed
the
feat/traces-metadata
branch
3 times, most recently
from
d63dc27 to
45c0f53
Compare
ka3de
force-pushed
the
feat/traces-metadata
branch
from
45c0f53 to
70ce2b0
Compare
This variable can be used to set extra metadata to be included when generating the iteration's root span.
Traces metadata are included in the root module so they can be parsed just once and shared for every VU. Parsing must happen in the NewModuleInstance call so we can use the VU's InitEnv environment lookup function, as well as aborth the test early if there is a format error.
This extra metadata, defined as string key-value pairs, will be included as attributes for every span generated from the tracer implementation.
Because the traces registry and its underlying tracer are only initialized on the first iterStart event for each VU, the browser registry must keep a reference to the traces metadata until this event is fired and the traces registry and tracer can be initialized.
ka3de
force-pushed
the
feat/traces-metadata
branch
from
70ce2b0 to
baa8024
Compare
This was referenced Dec 18, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds support for traces metadata, which allows users to specify extra key-value fields to be included as attributes for the generated traces.
Why?
Allows to define extra attributes that can then be used to query traces from the backend (e.g.: Tempo).
Checklist
Related PR(s)/Issue(s)
Related: #1100