Add throttleNetwork on page #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
add/network-throttle
branch
from
a96df23 to
0c7b9b2
Compare
ankur22
commented
Nov 9, 2023
ankur22
force-pushed
the
add/network-throttle
branch
from
0c7b9b2 to
793c9c5
Compare
ankur22
force-pushed
the
add/network-throttle
branch
2 times, most recently
from
a38f32c to
16c8a12
Compare
This is the bare bones mapping and implementation. It also adds the necessary new NetworkProfile type to enable this to work.
This adds the implementation to call chrome to perform the CDP request which will throttle the network in chrome itself.
A page can be made up of many frames, and each frame has its own session. This session maps directly to one in chrome. Generally a website will have one main frame. The new throttling api is scoped to the page so all the frames will need to have their sessions updated for a single page. This change helps with that.
Now we wire up the page with the frames.
The state of the network profile needs to be stored in memory so that it isn't overriden when the offline state is changed with setOffline.
Renaming them by removing throughput. It should be clear from the context that they reference the throughput and not any other aspect of the network.
ankur22
force-pushed
the
add/network-throttle
branch
from
98693e5 to
ba04a12
Compare
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds a new
throttleNetworkAPI onpagewhich throttles the network from chrome's perspective.Why?
A good use case for throttling the network is to see (within a lab environment) how the frontend reacts when the network is slow, e.g. on a slow 3G connection. With new measurements under a constraint network, users will be able to fine tune their website so that the most important information is returned in an acceptable timeframe.
Checklist
Related PR(s)/Issue(s)
Updates #887