Update browser_web_vital_fcp max threshold #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
fix/multiple-scenario.js
branch
from
c548667 to
b2b5e0c
Compare
|
This isn't needed. It was a temporary blip. |
|
@inancgumus yeah, i'd be happy to increase the threshold to a high number because when the site is being load tested it basically fails our CI. Should increase it to 5 seconds? |
|
@ankur22 5 sec makes sense 👍 |
We're seeing errors in the CI due to the test website being a bit slow. It feels like it's better to increase the threshold to account for a slow test site due to other load tests being performed against it.
ankur22
force-pushed
the
fix/multiple-scenario.js
branch
from
b2b5e0c to
1509dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Increasing the max threshold from 1s to 5s for the
browser_web_vital_fcpmetric in themultiple-scenario.jsexample test script.Why?
We're seeing errors in the CI due to the test website being a bit slow since it's continuously being load tested. It feels like it's better to increase the threshold to account for a slow test site due to other load tests being performed against it.
Checklist
Related PR(s)/Issue(s)