Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Instrument page.waitForTimeout #1426

Closed
2 tasks done
ankur22 opened this issue Sep 13, 2024 · 0 comments
Closed
2 tasks done

Instrument page.waitForTimeout #1426

ankur22 opened this issue Sep 13, 2024 · 0 comments
Assignees
Labels
feature A new feature

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Sep 13, 2024

What

We need to instrument page.waitForTimeout with traces like we have done for some other APIs that we have (e.g. page.waitForNavigation).

Why

This is needed so that we can eventually make it clear with the page.waitForTimeout span when the test is performing some sort "sleep"/"wait" call to mimic user behaviour. e.g.:

  1. Navigate to a website.
  2. run page.waitForTimeout for a second to mimic the website user looking for a particular element.

At the moment it is not clear why the span for a page can be long, when it's usually due to the (current) use of sleep.

This would also align better with Playwright.

Tasks

Preview Give feedback
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

No branches or pull requests

1 participant