Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor goja runtime value parsing out of page.waitForFunction promise #1181

Closed
2 tasks done
Tracked by #1162
ankur22 opened this issue Jan 22, 2024 · 0 comments
Closed
2 tasks done
Tracked by #1162
Assignees
Labels
bug Something isn't working

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Jan 22, 2024

What

Refactor the parsing of the option out of the promise and into the mapping layer for page.waitForFunction.

Why

This will help avoid a scenario where more than one off main goja thread goroutine (i.e. promise) is ran concurrently which could try to access the goja runtime concurrently and cause a panic.

How

Tasks

@ankur22 ankur22 changed the title Fix page.waitForFunction Refactor goja runtime value parsing out of page.waitForFunction promise Jan 22, 2024
@ankur22 ankur22 self-assigned this Jan 22, 2024
@ankur22 ankur22 added the bug Something isn't working label Jan 22, 2024
@ankur22 ankur22 closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant