Skip to content

Commit

Permalink
Fix TestBrowserOptionsSlowMo dispatch event
Browse files Browse the repository at this point in the history
  • Loading branch information
inancgumus committed Jan 25, 2024
1 parent 6c0ca77 commit b5c4e98
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/launch_options_slowmo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"testing"

"github.com/dop251/goja"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

Expand All @@ -13,7 +12,6 @@ import (

func TestBrowserOptionsSlowMo(t *testing.T) {
t.Parallel()
t.Skip("TODO: fix goja escape")

if testing.Short() {
t.Skip()
Expand Down Expand Up @@ -47,7 +45,8 @@ func TestBrowserOptionsSlowMo(t *testing.T) {
t.Parallel()
tb := newTestBrowser(t, withFileServer())
testPageSlowMoImpl(t, tb, func(_ *testBrowser, p *common.Page) {
p.DispatchEvent("button", "click", goja.Null(), nil)
err := p.DispatchEvent("button", "click", nil, common.NewFrameDispatchEventOptions(p.Timeout()))
require.NoError(t, err)
})
})
t.Run("emulateMedia", func(t *testing.T) {
Expand Down Expand Up @@ -195,7 +194,8 @@ func TestBrowserOptionsSlowMo(t *testing.T) {
t.Parallel()
tb := newTestBrowser(t, withFileServer())
testFrameSlowMoImpl(t, tb, func(_ *testBrowser, f *common.Frame) {
f.DispatchEvent("button", "click", goja.Null(), nil)
err := f.DispatchEvent("button", "click", nil, common.NewFrameDispatchEventOptions(f.Timeout()))
require.NoError(t, err)
})
})
t.Run("evaluate", func(t *testing.T) {
Expand Down

0 comments on commit b5c4e98

Please sign in to comment.