Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tk tool charts vendor idempotence #419

Closed
craigfurman opened this issue Nov 6, 2020 · 5 comments
Closed

tk tool charts vendor idempotence #419

craigfurman opened this issue Nov 6, 2020 · 5 comments

Comments

@craigfurman
Copy link
Contributor

It'd be neat if tk tool charts vendor was idempotent, clobbering the contents of ./charts with whatever is specified in chartfile.yaml. In this way its behavior would be similar to jb install or other dependency management commands.

What do you think of this idea? Would you be interested in a PR that implements it?

@sh0rez
Copy link
Member

sh0rez commented Nov 6, 2020

Loving it! Go ahead with a PR and feel free to reach out to me or any other team member if you get stuck :)

@craigfurman
Copy link
Contributor Author

The behavior in tk 0.12 (exiting with an error when tk tool charts vendor is called for an already vendored chart) has been changed to not exit with an error in #402 and #401.

I propose to change this to overwrite charts with the version specified in chartfile.yaml, if a different version is already downloaded. PR incoming.

@craigfurman
Copy link
Contributor Author

I've implemented this in #420. Let me know what you think!

@stale
Copy link

stale bot commented Dec 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 6, 2020
@stale stale bot removed the stale label Dec 6, 2020
@Duologic
Copy link
Member

Thank you for your contribution, #420 is merged and available in v0.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants