jsonnet-bundler binary env var #271
Labels
component/cli
Command Line Interface
good first issue
Good for newcomers
help wanted
Extra attention is needed
Currently we hard-code to use the binary called
jb
on the$PATH
ininit.go
:tanka/cmd/tk/init.go
Lines 74 to 76 in 6941b87
To be more resilient to differently set up environments, we should allow to set an
TANKA_JB_PATH
, similar to the existingTANKA_KUBECTL_PATH
: https://tanka.dev/env-vars#tanka_kubectl_pathSteps to implement:
Use
os.Getenv("TANKA_JB_PATH")
to read the env var, but default to"jb"
if unset, as already done forkubectl
:tanka/pkg/kubernetes/client/exec.go
Lines 14 to 17 in 6941b87
Put the result of that into the
exec.LookPath
call, keep the error checking:tanka/cmd/tk/init.go
Lines 74 to 76 in 6941b87
Update the docs to include the new env var in
docs/docs/env-vars.md
.The text was updated successfully, but these errors were encountered: