Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update location from where kubectl is downloaded from #1257

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

zerok
Copy link
Contributor

@zerok zerok commented Dec 2, 2024

Seems like the location changed around 1.31.0. The new location also includes the current patch release and thereby updating kubectl to 1.31.3.

Seems like the location changed around 1.31.0. The new location also
includes the current patch release.
@zerok zerok requested a review from a team as a code owner December 2, 2024 09:42
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

As a next piece of work: it would be better if the version was a variable in the Dockerfile.

Two main reasons:

  1. It could be updated by Renovate if we adopted that, and then we would get new images as new kubectl releases come out, not just when we get a build for another reason.
  2. Image builds would become (a bit more) reproducible: build the same thing, get the same kubectl version as last time, not just always the latest - a moving target. That also means if compatibility breaks then we can hold off until it's fixed & previous images can still be built.

@zerok
Copy link
Contributor Author

zerok commented Dec 2, 2024

👍

As a next piece of work: it would be better if the version was a variable in the Dockerfile.

Two main reasons:

  1. It could be updated by Renovate if we adopted that, and then we would get new images as new kubectl releases come out, not just when we get a build for another reason.
  2. Image builds would become (a bit more) reproducible: build the same thing, get the same kubectl version as last time, not just always the latest - a moving target. That also means if compatibility breaks then we can hold off until it's fixed & previous images can still be built.

Sounds good as a follow-up 🙂 This PR just fixes the status-quo and should end up in the next patch release (ideally in the next couple of days) to get past some SLO check. Will create an issue for the long-term fix 🙂

@iainlane
Copy link
Member

iainlane commented Dec 2, 2024

Sounds good as a follow-up 🙂 This PR just fixes the status-quo and should end up in the next patch release (ideally in the next couple of days) to get past some SLO check. Will create an issue for the long-term fix 🙂

Yeah, that's what I meant with

As a next piece of work

In case it wasn't clear

@zerok
Copy link
Contributor Author

zerok commented Dec 2, 2024

It was mostly clear but the review lacked an approval 😉

@iainlane
Copy link
Member

iainlane commented Dec 2, 2024

Ah sorry, I thought I had approved - I did mean to.........

@zerok zerok added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit c18e134 Dec 2, 2024
13 checks passed
@zerok zerok deleted the zerok/kubectl-upgrade branch December 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants