Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty labels when validating check #976

Open
ckbedwell opened this issue Nov 1, 2024 · 1 comment
Open

Ignore empty labels when validating check #976

ckbedwell opened this issue Nov 1, 2024 · 1 comment
Labels
bug Something isn't working frontend Needs to be implemented in the frontend application good first issue Good for newcomers

Comments

@ckbedwell
Copy link
Contributor

ckbedwell commented Nov 1, 2024 •
edited
Loading

Problem

If you add a label entry but don't fill it in we don't allow check creation. This can wrongfully make users think they have to add a label.

Acceptance Criteria

Ignore labels which don't have a key or value when validating check submission.

Please ensure the correct integration tests have been added in your fix.

Context

Mitch's walkthrough video 🙏
@ckbedwell ckbedwell added bug Something isn't working frontend Needs to be implemented in the frontend application good first issue Good for newcomers labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend Needs to be implemented in the frontend application good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckbedwell and others