Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not submit Check form when starting adhoc test of check #1026

Open
w1kman opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1037
Open

Do not submit Check form when starting adhoc test of check #1026

w1kman opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1037
Assignees
Labels
enhancement New feature or request frontend Needs to be implemented in the frontend application

Comments

@w1kman
Copy link
Contributor

w1kman commented Dec 19, 2024

What would you like to be added:
Currently, the "Test"-button ("execution" section) will submit the Check form, rendering the formState to be (technically) saved, when in fact the check has not been saved.
Any logic that revolves around wether or not the check has been saved or not stops working the second the "Test"-button is clicked.

I propose that the ad-hoc check is performed without submitting the form, which would let us leverage the built-in functionality of react-form-hook. Submitting the form equals saving the form data (saving the check).

The "Test"-button could/should include all the required logic to POST the form data (without submitting the actual form) to the ad-hoc check as well as render the result modal.

Affected features

  • Disable "Save" button when there are no modifications to the Check (or modifications are reset)
  • Prompt when leaving unsaved form

Why is this needed:

Additional context
see #1024

@w1kman w1kman added enhancement New feature or request frontend Needs to be implemented in the frontend application labels Dec 19, 2024
@ckbedwell ckbedwell linked a pull request Jan 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Needs to be implemented in the frontend application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants