Feature: add retries to ICMP prober #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a retry mechanism to the ICMP prober. If the packet count is not set, use 3 packets instead of 1, and require that at least 1 of them gets a response. This should cover most reasonable scenarios where retries are needed. Note that this will send out 3 packets regardless of whether 1 is already received, so this has an impact on the probe_duration_seconds metric (because the probe takes longer to run). If the time for an individual packet is important, use `sum(probe_icmp_duration_seconds)` instead. That metric is split by phases, and the `rtt` phase is the average round-trip-time for all the received packets. The other two phases, `setup` and `resolve` only run once. The resolve part of this also retries, in the event that the DNS server fails to produce a response and there's an indication that the request should be retried (e.g. if the response is "not found", that is not retried). Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
added a commit
that referenced
this pull request
Sep 19, 2024
* Feature: add retries to ICMP prober (#896) * Fix: allow probers to provide a duration value (#898) Signed-off-by: Marcelo E. Magallon <[email protected]>
Merged
mem
added a commit
that referenced
this pull request
Sep 19, 2024
* Feature: add retries to ICMP prober (#896) * Fix: allow probers to provide a duration value (#898) Signed-off-by: Marcelo E. Magallon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a retry mechanism to the ICMP prober. If the packet count is not set, use 3 packets instead of 1, and require that at least 1 of them gets a response. This should cover most reasonable scenarios where retries are needed.
Note that this will send out 3 packets regardless of whether 1 is already received, so this has an impact on the probe_duration_seconds metric (because the probe takes longer to run).
If the time for an individual packet is important, use
sum(probe_icmp_duration_seconds)instead. That metric is split by phases, and therttphase is the average round-trip-time for all the received packets. The other two phases,setupandresolveonly run once.The resolve part of this also retries, in the event that the DNS server fails to produce a response and there's an indication that the request should be retried (e.g. if the response is "not found", that is not retried).