Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate browser capability #809

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

ka3de
Copy link
Contributor

@ka3de ka3de commented Jul 30, 2024

k6 functionality is required in the agent by default, and is NOT required only in case both, scripted and browser checks, have been disabled for the probe from the API.

Updates: https://github.com/grafana/synthetic-monitoring/issues/116

@ka3de ka3de changed the title Validate browser capability feat: Validate browser capability Jul 30, 2024
Base automatically changed from add-browser-checks-capability to main July 31, 2024 08:17
k6 functionality is required in the agent by default, and is only NOT
required in case both, scripted and browser checks, have been disabled
for the probe from the API.
@ka3de ka3de force-pushed the validate-browser-capability branch from 9849be2 to 971b00e Compare August 29, 2024 10:43
@ka3de ka3de marked this pull request as ready for review August 29, 2024 10:47
@ka3de ka3de requested a review from a team as a code owner August 29, 2024 10:47
Copy link
Member

@nadiamoe nadiamoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice, just one small nit

internal/checks/checks_test.go Show resolved Hide resolved
@ka3de ka3de merged commit f94214e into main Sep 2, 2024
2 checks passed
@ka3de ka3de deleted the validate-browser-capability branch September 2, 2024 09:37
ka3de added a commit that referenced this pull request Sep 2, 2024
* k6runner: always log error code and string to user's logger
* Update module golang.org/x/sync to v0.8.0 (#812)
* Update module golang.org/x/net to v0.28.0 (#813)
* Build(deps): Bump the prometheus-go group across 1 directory with 2 updates (#827)
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.22.0 (#817)
* Update module go.k6.io/k6 to v0.53.0 (#823)
* Update dependency grafana/k6 to v0.53.0
* Update module github.com/miekg/dns to v1.1.62
* Update github.com/grafana/loki/pkg/push digest to 9315b3d
* Update golang.org/x/exp digest to 9b4947d
* Update github.com/securego/gosec/v2 digest to ab3f6c1
* Update github.com/grafana/loki/pkg/push digest to 246a1df
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.23.0
* Build(deps): Bump github.com/prometheus/client_golang
* Update module github.com/securego/gosec to v2
* renovate: fix grafana-build-tools dependency regex
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.23.0
* drone: regenerate pipelines
* Add with-browser Docker image (#829)
* Update module github.com/prometheus/prometheus to v0.54.1 (#843)
* Update module github.com/prometheus/common to v0.56.0 (#849)
* Build(deps): Bump google.golang.org/grpc from 1.65.0 to 1.66.0
* Build(deps): Bump github.com/prometheus/common
* renovate: group prometheus-go updates
* renovate: enable default managers
* renovate: add `dependencies` label to PRs
* dependabot: remove
* Update renovatebot/github-action action to v40.2.7 (#859)
* go: upgrade to 1.23 (#838)
* Update module github.com/golangci/golangci-lint to v1.60.0 (#825)
* Update alpine Docker tag to v3.20 (#858)
* Update actions/checkout action to v4.1.7 (#857)
* Dockerfile: pin hash of debian:stable-slim image (#828)
* Update module github.com/mccutchen/go-httpbin/v2 to v2.14.1 (#860)
* Update module github.com/securego/gosec to v2 (#861)
* feat: Validate browser capability (#809)

Signed-off-by: ka3de <[email protected]>
@ka3de ka3de mentioned this pull request Sep 2, 2024
ka3de added a commit that referenced this pull request Sep 2, 2024
* k6runner: always log error code and string to user's logger
* Update module golang.org/x/sync to v0.8.0 (#812)
* Update module golang.org/x/net to v0.28.0 (#813)
* Build(deps): Bump the prometheus-go group across 1 directory with 2 updates (#827)
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.22.0 (#817)
* Update module go.k6.io/k6 to v0.53.0 (#823)
* Update dependency grafana/k6 to v0.53.0
* Update module github.com/miekg/dns to v1.1.62
* Update github.com/grafana/loki/pkg/push digest to 9315b3d
* Update golang.org/x/exp digest to 9b4947d
* Update github.com/securego/gosec/v2 digest to ab3f6c1
* Update github.com/grafana/loki/pkg/push digest to 246a1df
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.23.0
* Build(deps): Bump github.com/prometheus/client_golang
* Update module github.com/securego/gosec to v2
* renovate: fix grafana-build-tools dependency regex
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.23.0
* drone: regenerate pipelines
* Add with-browser Docker image (#829)
* Update module github.com/prometheus/prometheus to v0.54.1 (#843)
* Update module github.com/prometheus/common to v0.56.0 (#849)
* Build(deps): Bump google.golang.org/grpc from 1.65.0 to 1.66.0
* Build(deps): Bump github.com/prometheus/common
* renovate: group prometheus-go updates
* renovate: enable default managers
* renovate: add `dependencies` label to PRs
* dependabot: remove
* Update renovatebot/github-action action to v40.2.7 (#859)
* go: upgrade to 1.23 (#838)
* Update module github.com/golangci/golangci-lint to v1.60.0 (#825)
* Update alpine Docker tag to v3.20 (#858)
* Update actions/checkout action to v4.1.7 (#857)
* Dockerfile: pin hash of debian:stable-slim image (#828)
* Update module github.com/mccutchen/go-httpbin/v2 to v2.14.1 (#860)
* Update module github.com/securego/gosec to v2 (#861)
* feat: Validate browser capability (#809)

Signed-off-by: ka3de <[email protected]>
ka3de added a commit that referenced this pull request Sep 2, 2024
* k6runner: always log error code and string to user's logger
* Update module golang.org/x/sync to v0.8.0 (#812)
* Update module golang.org/x/net to v0.28.0 (#813)
* Build(deps): Bump the prometheus-go group across 1 directory with 2 updates (#827)
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.22.0 (#817)
* Update module go.k6.io/k6 to v0.53.0 (#823)
* Update dependency grafana/k6 to v0.53.0
* Update module github.com/miekg/dns to v1.1.62
* Update github.com/grafana/loki/pkg/push digest to 9315b3d
* Update golang.org/x/exp digest to 9b4947d
* Update github.com/securego/gosec/v2 digest to ab3f6c1
* Update github.com/grafana/loki/pkg/push digest to 246a1df
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.23.0
* Build(deps): Bump github.com/prometheus/client_golang
* Update module github.com/securego/gosec to v2
* renovate: fix grafana-build-tools dependency regex
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.23.0
* drone: regenerate pipelines
* Add with-browser Docker image (#829)
* Update module github.com/prometheus/prometheus to v0.54.1 (#843)
* Update module github.com/prometheus/common to v0.56.0 (#849)
* Build(deps): Bump google.golang.org/grpc from 1.65.0 to 1.66.0
* Build(deps): Bump github.com/prometheus/common
* renovate: group prometheus-go updates
* renovate: enable default managers
* renovate: add `dependencies` label to PRs
* dependabot: remove
* Update renovatebot/github-action action to v40.2.7 (#859)
* go: upgrade to 1.23 (#838)
* Update module github.com/golangci/golangci-lint to v1.60.0 (#825)
* Update alpine Docker tag to v3.20 (#858)
* Update actions/checkout action to v4.1.7 (#857)
* Dockerfile: pin hash of debian:stable-slim image (#828)
* Update module github.com/mccutchen/go-httpbin/v2 to v2.14.1 (#860)
* Update module github.com/securego/gosec to v2 (#861)
* feat: Validate browser capability (#809)

Signed-off-by: ka3de <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants