Experimental: increase max frequency to 1 hour #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the maximum interval between successive check runs to be up to 1 hour. This will break some dashboards, because there are built-in assumptions about the maximum value being 2 minutes. In particular, it's going to be necessary to adjust the value we use for ranges, which is hard-coded to 5 minutes. If we change the queries, we still need to adjust values in Grafana, to prevent sampling values at intervals less than the frequency. This is going to be particularly visible in queries that use `increase`, `rate` and similar functions. Because of that, this is mostly about adding backend support for [issue #318](grafana/synthetic-monitoring-app#318). Signed-off-by: Marcelo E. Magallon <[email protected]>
ka3de
approved these changes
Mar 11, 2024
mem
added a commit
that referenced
this pull request
Mar 14, 2024
* Experimental: increase max frequency to 1 hour (#645) * Feature: switch to pusher v2 by default (#655) * Clean up scraper factory (#656) * Chore(deps): Bump google.golang.org/protobuf in /scripts/go (#657) Signed-off-by: Marcelo E. Magallon <[email protected]>
Merged
mem
added a commit
that referenced
this pull request
Mar 14, 2024
* Experimental: increase max frequency to 1 hour (#645) * Feature: switch to pusher v2 by default (#655) * Clean up scraper factory (#656) * Chore(deps): Bump google.golang.org/protobuf in /scripts/go (#657) Signed-off-by: Marcelo E. Magallon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the maximum interval between successive check runs to be up to 1 hour. This will break some dashboards, because there are built-in assumptions about the maximum value being 2 minutes. In particular, it's going to be necessary to adjust the value we use for ranges, which is hard-coded to 5 minutes. If we change the queries, we still need to adjust values in Grafana, to prevent sampling values at intervals less than the frequency. This is going to be particularly visible in queries that use
increase,rateand similar functions. Because of that, this is mostly about adding backend support for issue #318.