New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent should validate validations #597

Closed

mem opened this issue Feb 1, 2024 · 0 comments · Fixed by #612

Assignees

Labels

bug

Contributor

mem commented Feb 1, 2024

It was reported that the agent is accepting regular expression validations with invalid regular expressions.

E.g. if fail_if_body_matches_regexp contains an invalid regular expression, the agent will consider the check to be valid.

That validation should be happening somewhere around here: https://github.com/grafana/synthetic-monitoring-agent/blob/main/pkg/pb/synthetic_monitoring/checks_extra.go#L574

mem added the bug label

peterschretlen assigned The-9880

The-9880 mentioned this issue

Fix: missing http check regex validations #612

Merged

The-9880 closed this as completed in #612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment