make the k6 runner timeout configurable #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a prober is created it gets a context that has the check's timeout added as the deadline for the context. The timeout is measured between the point where the probe is started and the point where it finishes running. For the MultiHTTP case, we _add_ the k6 start up time to that, because this behavior is consistent with the way the other checks work. Signed-off-by: Marcelo E. Magallon <[email protected]>
Signed-off-by: Marcelo E. Magallon <[email protected]>
Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
approved these changes
Nov 3, 2023
mem
added a commit
that referenced
this pull request
Nov 7, 2023
* Feature: add k6 to docker image * Fix: add k6 binary to release files * Fix: add a `name` label to metrics * Fix: make the k6 runner timeout configurable (#554) * Add example configuration files for test-api (#557) * Upgrade dependencies * Fix RunRequest definition Signed-off-by: Marcelo E. Magallon <[email protected]>
Merged
mem
added a commit
that referenced
this pull request
Nov 7, 2023
* Feature: add k6 to docker image * Fix: add k6 binary to release files * Fix: add a `name` label to metrics * Fix: make the k6 runner timeout configurable (#554) * Add example configuration files for test-api (#557) * Upgrade dependencies * Fix RunRequest definition Signed-off-by: Marcelo E. Magallon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the k6runner timeout is hardcoded to 10 seconds. This makes it reflect the check timeout.
Not sure this is the best approach