Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: increase SHA-1 short version length #1092

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mem
Copy link
Contributor

@mem mem commented Dec 10, 2024

It's been observed that two different runs of git produce two different values of the short SHA-1 value (which is weird, because this is supposed to be based on the number of objects in the repository). Fix this at 12, because that is longer than what git automatically decides to use.

It's been observed that two different runs of git produce two different
values of the short SHA-1 value (which is weird, because this is
supposed to be based on the number of objects in the repository). Fix
this at 12, because that is longer than what git automatically decides
to use.

Signed-off-by: Marcelo E. Magallon <[email protected]>
@mem mem requested a review from a team as a code owner December 10, 2024 00:18
Copy link

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckbedwell ckbedwell merged commit a09f85d into main Dec 10, 2024
5 checks passed
@ckbedwell ckbedwell deleted the mem/increase-sha-1-length-in-version branch December 10, 2024 14:57
@sm-release-app sm-release-app bot mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants