Support block planning for SelectSeries API. #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
About panic: unknown row type: phlaredb.ProfileWithLabels in tests: we need to make sure phlaredb.ProfileWithLabels implements the RowGetter interface https://github.com/grafana/pyroscope/blob/main/pkg/phlaredb/query/iters.go#L738
Otherwise, LGTM
Co-authored-by: Anton Kolesnikov <[email protected]>
Co-authored-by: Anton Kolesnikov <[email protected]>
Yeah I'm looking into this. |
cyriltovena
added a commit
that referenced
this pull request
Nov 15, 2023
* Support block planning for SelectSeries API. * Fixes tests * Avoids panics when no blocks * Fixes gap in metrics * Update pkg/querier/ingester_querier.go Co-authored-by: Anton Kolesnikov <[email protected]> * Update pkg/querier/store_gateway_querier.go Co-authored-by: Anton Kolesnikov <[email protected]> * Fixes messup with iterators * Fixes querier downstream queries --------- Co-authored-by: Anton Kolesnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.