Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add helm configuration for Azure OIDC federation #9168

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Re-add helm configuration for Azure OIDC federation #9168

merged 1 commit into from
Apr 20, 2023

Conversation

Tolsto
Copy link
Contributor

@Tolsto Tolsto commented Apr 17, 2023 •
edited
Loading

What this PR does / why we need it:

This re-adds the configuration that was removed in #8515

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@Tolsto Tolsto requested review from JStickler and a team as code owners April 17, 2023 18:13
@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Apr 17, 2023
@Tolsto Tolsto force-pushed the readd-azure-oidc-federation-helm-config branch 4 times, most recently from 7f06c16 to 44b83da Compare April 18, 2023 06:28
@Tolsto Tolsto force-pushed the readd-azure-oidc-federation-helm-config branch from 44b83da to 9e9527f Compare April 18, 2023 06:33
@JStickler
Copy link
Contributor

@Tolsto this configuration was removed in #8515 because "the setting is still unreleased" and I can't find anything in the CHANGELOG to indicate that is has been released. Maybe I'm missing something?

@Tolsto
Copy link
Contributor Author

Tolsto commented Apr 18, 2023 •
edited
Loading

@Tolsto this configuration was removed in #8515 because "the setting is still unreleased" and I can't find anything in the CHANGELOG to indicate that is has been released. Maybe I'm missing something?

This was released as part of 2.8.0. Feature was merged here: #7540

JStickler
JStickler approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Thank you, I had searched for a PR but apparently I didn't search hard enough. Docs LGTM.

@jeschkies jeschkies merged commit afee8bc into grafana:main Apr 20, 2023
@jeschkies jeschkies mentioned this pull request Apr 20, 2023
Closed
5 tasks
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@Tolsto
Re-add helm configuration for Azure OIDC federation (grafana#9168)
6d4acd8 
**What this PR does / why we need it**:

This re-adds the configuration that was removed in
grafana#8515

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

@jeschkies jeschkies jeschkies approved these changes

Assignees
No one assigned
Labels
area/helm size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tolsto @JStickler @jeschkies