From 9cad466e8fc2aa08910d5fc7d26450b81ede8e2a Mon Sep 17 00:00:00 2001 From: Cyril Tovena Date: Mon, 11 Apr 2022 09:24:49 +0200 Subject: [PATCH 1/2] Improve write dashboard by removing unrelated route Signed-off-by: Cyril Tovena --- production/loki-mixin/dashboards/loki-writes.libsonnet | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/production/loki-mixin/dashboards/loki-writes.libsonnet b/production/loki-mixin/dashboards/loki-writes.libsonnet index 0be7acd815cfd..99ffbb06e4d31 100644 --- a/production/loki-mixin/dashboards/loki-writes.libsonnet +++ b/production/loki-mixin/dashboards/loki-writes.libsonnet @@ -54,13 +54,13 @@ local utils = import 'mixin-utils/utils.libsonnet'; $.row('Distributor') .addPanel( $.panel('QPS') + - $.qpsPanel('loki_request_duration_seconds_count{%s}' % std.rstripChars(dashboards['loki-writes.json'].distributorSelector, ',')) + $.qpsPanel('loki_request_duration_seconds_count{%s route=~"api_prom_push|loki_api_v1_push|/httpgrpc.HTTP/Handle"}' % std.rstripChars(dashboards['loki-writes.json'].distributorSelector, ',')) ) .addPanel( $.panel('Latency') + utils.latencyRecordingRulePanel( 'loki_request_duration_seconds', - dashboards['loki-writes.json'].matchers.distributor, + dashboards['loki-writes.json'].matchers.distributor + [utils.selector.re('route', 'api_prom_push|loki_api_v1_push|/httpgrpc.HTTP/Handle')], extra_selectors=dashboards['loki-writes.json'].clusterMatchers ) ) From 26a2f5771241a12b6944659f03a3d1fea5172d2b Mon Sep 17 00:00:00 2001 From: Cyril Tovena Date: Thu, 14 Apr 2022 14:49:01 +0200 Subject: [PATCH 2/2] Update production/loki-mixin/dashboards/loki-writes.libsonnet Co-authored-by: Sandeep Sukhani --- production/loki-mixin/dashboards/loki-writes.libsonnet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/production/loki-mixin/dashboards/loki-writes.libsonnet b/production/loki-mixin/dashboards/loki-writes.libsonnet index 99ffbb06e4d31..b5133ce2bf69c 100644 --- a/production/loki-mixin/dashboards/loki-writes.libsonnet +++ b/production/loki-mixin/dashboards/loki-writes.libsonnet @@ -54,7 +54,7 @@ local utils = import 'mixin-utils/utils.libsonnet'; $.row('Distributor') .addPanel( $.panel('QPS') + - $.qpsPanel('loki_request_duration_seconds_count{%s route=~"api_prom_push|loki_api_v1_push|/httpgrpc.HTTP/Handle"}' % std.rstripChars(dashboards['loki-writes.json'].distributorSelector, ',')) + $.qpsPanel('loki_request_duration_seconds_count{%s, route=~"api_prom_push|loki_api_v1_push|/httpgrpc.HTTP/Handle"}' % std.rstripChars(dashboards['loki-writes.json'].distributorSelector, ',')) ) .addPanel( $.panel('Latency') +