From 8a63ba89021c6f807359e8ed57b1710b87e42125 Mon Sep 17 00:00:00 2001 From: Trevor Whitney Date: Fri, 7 Jan 2022 11:19:17 -0700 Subject: [PATCH 01/10] improve default config values --- docs/sources/configuration/_index.md | 14 +++++++------- pkg/ingester/ingester.go | 2 +- pkg/querier/querier.go | 4 ++-- .../cortex/pkg/querier/queryrange/roundtrip.go | 6 +++--- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/docs/sources/configuration/_index.md b/docs/sources/configuration/_index.md index cd03167930755..d9e5161e1f995 100644 --- a/docs/sources/configuration/_index.md +++ b/docs/sources/configuration/_index.md @@ -276,11 +276,11 @@ The `querier` block configures the Loki Querier. # Maximum lookback beyond which queries are not sent to ingester. # 0 means all queries are sent to ingester. # CLI flag: -querier.query-ingesters-within -[query_ingesters_within: | default = 0s] +[query_ingesters_within: | default = 2h] # The maximum number of concurrent queries allowed. # CLI flag: -querier.max-concurrent -[max_concurrent: | default = 20] +[max_concurrent: | default = 10] # Only query the store, do not attempt to query any ingesters, # useful for running a standalone querier pool opearting only against stored data. @@ -378,7 +378,7 @@ The `query_range` block configures query splitting and caching in the Loki query # Mutate incoming queries to align their start and end with their step. # CLI flag: -querier.align-querier-with-step -[align_queries_with_step: | default = false] +[align_queries_with_step: | default = true] results_cache: # The CLI flags prefix for this block config is: frontend @@ -396,7 +396,7 @@ results_cache: # Perform query parallelisations based on storage sharding configuration and # query ASTs. This feature is supported only by the chunks storage engine. # CLI flag: -querier.parallelise-shardable-queries -[parallelise_shardable_queries: | default = false] +[parallelise_shardable_queries: | default = true] ``` ## ruler @@ -1009,7 +1009,7 @@ lifecycler: # Number of times to try and transfer chunks when leaving before # falling back to flushing to the store. Zero = no transfers are done. # CLI flag: -ingester.max-transfer-retries -[max_transfer_retries: | default = 10] +[max_transfer_retries: | default = 0] # How many flushes can happen concurrently from each stream. # CLI flag: -ingester.concurrent-flushes @@ -1073,7 +1073,7 @@ lifecycler: # The maximum duration of a timeseries chunk in memory. If a timeseries runs for longer than this, # the current chunk will be flushed to the store and a new chunk created. # CLI flag: -ingester.max-chunk-age -[max_chunk_age: | default = 1h] +[max_chunk_age: | default = 2h] # How far in the past an ingester is allowed to query the store for data. # This is only useful for running multiple Loki binaries with a shared ring @@ -2167,7 +2167,7 @@ The `limits_config` block configures global and per-tenant limits in Loki. # to avoid queriers downloading and processing the same chunks. This also # determines how cache keys are chosen when result caching is enabled # CLI flag: -querier.split-queries-by-interval -[split_queries_by_interval: | default = 0s] +[split_queries_by_interval: | default = 30m] ``` ### grpc_client_config diff --git a/pkg/ingester/ingester.go b/pkg/ingester/ingester.go index 544bfa9918d3f..64ca66433b3b6 100644 --- a/pkg/ingester/ingester.go +++ b/pkg/ingester/ingester.go @@ -106,7 +106,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) { f.DurationVar(&cfg.SyncPeriod, "ingester.sync-period", 0, "How often to cut chunks to synchronize ingesters.") f.Float64Var(&cfg.SyncMinUtilization, "ingester.sync-min-utilization", 0, "Minimum utilization of chunk when doing synchronization.") f.IntVar(&cfg.MaxReturnedErrors, "ingester.max-ignored-stream-errors", 10, "Maximum number of ignored stream errors to return. 0 to return all errors.") - f.DurationVar(&cfg.MaxChunkAge, "ingester.max-chunk-age", time.Hour, "Maximum chunk age before flushing.") + f.DurationVar(&cfg.MaxChunkAge, "ingester.max-chunk-age", 2*time.Hour, "Maximum chunk age before flushing.") f.DurationVar(&cfg.QueryStoreMaxLookBackPeriod, "ingester.query-store-max-look-back-period", 0, "How far back should an ingester be allowed to query the store for data, for use only with boltdb-shipper index and filesystem object store. -1 for infinite.") f.BoolVar(&cfg.AutoForgetUnhealthy, "ingester.autoforget-unhealthy", false, "Enable to remove unhealthy ingesters from the ring after `ring.kvstore.heartbeat_timeout`") f.IntVar(&cfg.IndexShards, "ingester.index-shards", index.DefaultIndexShards, "Shard factor used in the ingesters for the in process reverse index. This MUST be evenly divisible by ALL schema shard factors or Loki will not start.") diff --git a/pkg/querier/querier.go b/pkg/querier/querier.go index 155863188e5ab..fba2797fff7e4 100644 --- a/pkg/querier/querier.go +++ b/pkg/querier/querier.go @@ -57,8 +57,8 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) { f.DurationVar(&cfg.TailMaxDuration, "querier.tail-max-duration", 1*time.Hour, "Limit the duration for which live tailing request would be served") f.DurationVar(&cfg.QueryTimeout, "querier.query-timeout", 1*time.Minute, "Timeout when querying backends (ingesters or storage) during the execution of a query request") f.DurationVar(&cfg.ExtraQueryDelay, "querier.extra-query-delay", 0, "Time to wait before sending more than the minimum successful query requests.") - f.DurationVar(&cfg.QueryIngestersWithin, "querier.query-ingesters-within", 0, "Maximum lookback beyond which queries are not sent to ingester. 0 means all queries are sent to ingester.") - f.IntVar(&cfg.MaxConcurrent, "querier.max-concurrent", 20, "The maximum number of concurrent queries.") + f.DurationVar(&cfg.QueryIngestersWithin, "querier.query-ingesters-within", 2*time.Hour, "Maximum lookback beyond which queries are not sent to ingester. 0 means all queries are sent to ingester.") + f.IntVar(&cfg.MaxConcurrent, "querier.max-concurrent", 10, "The maximum number of concurrent queries.") f.BoolVar(&cfg.QueryStoreOnly, "querier.query-store-only", false, "Queriers should only query the store and not try to query any ingesters") } diff --git a/vendor/github.com/cortexproject/cortex/pkg/querier/queryrange/roundtrip.go b/vendor/github.com/cortexproject/cortex/pkg/querier/queryrange/roundtrip.go index 4620ff4e458df..e6503ec4dbbe2 100644 --- a/vendor/github.com/cortexproject/cortex/pkg/querier/queryrange/roundtrip.go +++ b/vendor/github.com/cortexproject/cortex/pkg/querier/queryrange/roundtrip.go @@ -67,10 +67,10 @@ type Config struct { // RegisterFlags adds the flags required to config this to the given FlagSet. func (cfg *Config) RegisterFlags(f *flag.FlagSet) { f.IntVar(&cfg.MaxRetries, "querier.max-retries-per-request", 5, "Maximum number of retries for a single request; beyond this, the downstream error is returned.") - f.DurationVar(&cfg.SplitQueriesByInterval, "querier.split-queries-by-interval", 0, "Split queries by an interval and execute in parallel, 0 disables it. You should use an a multiple of 24 hours (same as the storage bucketing scheme), to avoid queriers downloading and processing the same chunks. This also determines how cache keys are chosen when result caching is enabled") - f.BoolVar(&cfg.AlignQueriesWithStep, "querier.align-querier-with-step", false, "Mutate incoming queries to align their start and end with their step.") + f.DurationVar(&cfg.SplitQueriesByInterval, "querier.split-queries-by-interval", 30*time.Minute, "Split queries by an interval and execute in parallel, 0 disables it. You should use an a multiple of 24 hours (same as the storage bucketing scheme), to avoid queriers downloading and processing the same chunks. This also determines how cache keys are chosen when result caching is enabled") + f.BoolVar(&cfg.AlignQueriesWithStep, "querier.align-querier-with-step", true, "Mutate incoming queries to align their start and end with their step.") f.BoolVar(&cfg.CacheResults, "querier.cache-results", false, "Cache query results.") - f.BoolVar(&cfg.ShardedQueries, "querier.parallelise-shardable-queries", false, "Perform query parallelisations based on storage sharding configuration and query ASTs. This feature is supported only by the chunks storage engine.") + f.BoolVar(&cfg.ShardedQueries, "querier.parallelise-shardable-queries", true, "Perform query parallelisations based on storage sharding configuration and query ASTs. This feature is supported only by the chunks storage engine.") f.Var(&cfg.ForwardHeaders, "frontend.forward-headers-list", "List of headers forwarded by the query Frontend to downstream querier.") cfg.ResultsCacheConfig.RegisterFlags(f) } From 2125c14f200ab6050b337e01d23dd475bf675aac Mon Sep 17 00:00:00 2001 From: Trevor Whitney Date: Fri, 7 Jan 2022 11:37:39 -0700 Subject: [PATCH 02/10] change defaults for upstream query range package --- pkg/loki/loki.go | 26 ++++++++++++++++++- .../pkg/querier/queryrange/roundtrip.go | 6 ++--- 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/pkg/loki/loki.go b/pkg/loki/loki.go index a3372cb86afab..39073cedfb573 100644 --- a/pkg/loki/loki.go +++ b/pkg/loki/loki.go @@ -105,7 +105,7 @@ func (c *Config) RegisterFlags(f *flag.FlagSet) { c.Frontend.RegisterFlags(f) c.Ruler.RegisterFlags(f) c.Worker.RegisterFlags(f) - c.QueryRange.RegisterFlags(f) + c.registerQueryRangeFlagsWithChangedDefaultValues(f) c.RuntimeConfig.RegisterFlags(f) c.MemberlistKV.RegisterFlags(f) c.Tracing.RegisterFlags(f) @@ -134,6 +134,30 @@ func (c *Config) registerServerFlagsWithChangedDefaultValues(fs *flag.FlagSet) { }) } +func (c *Config) registerQueryRangeFlagsWithChangedDefaultValues(fs *flag.FlagSet) { + throwaway := flag.NewFlagSet("throwaway", flag.PanicOnError) + + // Register to throwaway flags first. Default values are remembered during registration and cannot be changed, + // but we can take values from throwaway flag set and reregister into supplied flags with new default values. + c.QueryRange.RegisterFlags(throwaway) + + throwaway.VisitAll(func(f *flag.Flag) { + // Ignore errors when setting new values. We have a test to verify that it works. + switch f.Name { + case "querier.split-queries-by-interval": + _ = f.Value.Set("30m") + + case "querier.align-querier-with-step": + _ = f.Value.Set("true") + + case "querier.parallelise-shardable-queries": + _ = f.Value.Set("true") + } + + fs.Var(f.Value, f.Name, f.Usage) + }) +} + // Clone takes advantage of pass-by-value semantics to return a distinct *Config. // This is primarily used to parse a different flag set without mutating the original *Config. func (c *Config) Clone() flagext.Registerer { diff --git a/vendor/github.com/cortexproject/cortex/pkg/querier/queryrange/roundtrip.go b/vendor/github.com/cortexproject/cortex/pkg/querier/queryrange/roundtrip.go index e6503ec4dbbe2..4620ff4e458df 100644 --- a/vendor/github.com/cortexproject/cortex/pkg/querier/queryrange/roundtrip.go +++ b/vendor/github.com/cortexproject/cortex/pkg/querier/queryrange/roundtrip.go @@ -67,10 +67,10 @@ type Config struct { // RegisterFlags adds the flags required to config this to the given FlagSet. func (cfg *Config) RegisterFlags(f *flag.FlagSet) { f.IntVar(&cfg.MaxRetries, "querier.max-retries-per-request", 5, "Maximum number of retries for a single request; beyond this, the downstream error is returned.") - f.DurationVar(&cfg.SplitQueriesByInterval, "querier.split-queries-by-interval", 30*time.Minute, "Split queries by an interval and execute in parallel, 0 disables it. You should use an a multiple of 24 hours (same as the storage bucketing scheme), to avoid queriers downloading and processing the same chunks. This also determines how cache keys are chosen when result caching is enabled") - f.BoolVar(&cfg.AlignQueriesWithStep, "querier.align-querier-with-step", true, "Mutate incoming queries to align their start and end with their step.") + f.DurationVar(&cfg.SplitQueriesByInterval, "querier.split-queries-by-interval", 0, "Split queries by an interval and execute in parallel, 0 disables it. You should use an a multiple of 24 hours (same as the storage bucketing scheme), to avoid queriers downloading and processing the same chunks. This also determines how cache keys are chosen when result caching is enabled") + f.BoolVar(&cfg.AlignQueriesWithStep, "querier.align-querier-with-step", false, "Mutate incoming queries to align their start and end with their step.") f.BoolVar(&cfg.CacheResults, "querier.cache-results", false, "Cache query results.") - f.BoolVar(&cfg.ShardedQueries, "querier.parallelise-shardable-queries", true, "Perform query parallelisations based on storage sharding configuration and query ASTs. This feature is supported only by the chunks storage engine.") + f.BoolVar(&cfg.ShardedQueries, "querier.parallelise-shardable-queries", false, "Perform query parallelisations based on storage sharding configuration and query ASTs. This feature is supported only by the chunks storage engine.") f.Var(&cfg.ForwardHeaders, "frontend.forward-headers-list", "List of headers forwarded by the query Frontend to downstream querier.") cfg.ResultsCacheConfig.RegisterFlags(f) } From 1fe1da95e27e532192c611645daf340078cc631c Mon Sep 17 00:00:00 2001 From: Trevor Whitney Date: Fri, 7 Jan 2022 11:39:51 -0700 Subject: [PATCH 03/10] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e8bd3df81cbfb..4eeaea6ea8af6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ * [4942](https://github.com/grafana/loki/pull/4942) **cyriltovena**: Allow to disable HTTP/2 for GCS. * [4876](https://github.com/grafana/loki/pull/4876) **trevorwhitney**: Docs: add simple, scalable example using docker-compose * [4857](https://github.com/grafana/loki/pull/4857) **jordanrushing**: New schema v12 changes chunk key structure +* [5077](https://github.com/grafana/loki/pull/5077) **trevorwhitney**: Change some default values for better out-of-the-box performance # 2.4.1 (2021/11/07) From ff9dd99bfd7439dddd9ad83bcfc2abc28bcacdb2 Mon Sep 17 00:00:00 2001 From: Trevor Whitney Date: Fri, 7 Jan 2022 11:47:19 -0700 Subject: [PATCH 04/10] remove max_tranfer_retries fix as it is covered in another PR, 4792 --- docs/sources/configuration/_index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sources/configuration/_index.md b/docs/sources/configuration/_index.md index d9e5161e1f995..9297e60ea9682 100644 --- a/docs/sources/configuration/_index.md +++ b/docs/sources/configuration/_index.md @@ -1009,7 +1009,7 @@ lifecycler: # Number of times to try and transfer chunks when leaving before # falling back to flushing to the store. Zero = no transfers are done. # CLI flag: -ingester.max-transfer-retries -[max_transfer_retries: | default = 0] +[max_transfer_retries: | default = 10] # How many flushes can happen concurrently from each stream. # CLI flag: -ingester.concurrent-flushes From 7f8c0ce1629485f053eba03c284ce720ee6669c2 Mon Sep 17 00:00:00 2001 From: Trevor Whitney Date: Mon, 10 Jan 2022 12:58:57 -0700 Subject: [PATCH 05/10] increase query ingesters within by 1h This provides an additional buffer on top of the max_chunk_age. Co-authored-by: Owen Diehl --- docs/sources/configuration/_index.md | 2 +- pkg/querier/querier.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/sources/configuration/_index.md b/docs/sources/configuration/_index.md index 9297e60ea9682..5f36c64a099a0 100644 --- a/docs/sources/configuration/_index.md +++ b/docs/sources/configuration/_index.md @@ -276,7 +276,7 @@ The `querier` block configures the Loki Querier. # Maximum lookback beyond which queries are not sent to ingester. # 0 means all queries are sent to ingester. # CLI flag: -querier.query-ingesters-within -[query_ingesters_within: | default = 2h] +[query_ingesters_within: | default = 3h] # The maximum number of concurrent queries allowed. # CLI flag: -querier.max-concurrent diff --git a/pkg/querier/querier.go b/pkg/querier/querier.go index fba2797fff7e4..215426d631440 100644 --- a/pkg/querier/querier.go +++ b/pkg/querier/querier.go @@ -57,7 +57,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) { f.DurationVar(&cfg.TailMaxDuration, "querier.tail-max-duration", 1*time.Hour, "Limit the duration for which live tailing request would be served") f.DurationVar(&cfg.QueryTimeout, "querier.query-timeout", 1*time.Minute, "Timeout when querying backends (ingesters or storage) during the execution of a query request") f.DurationVar(&cfg.ExtraQueryDelay, "querier.extra-query-delay", 0, "Time to wait before sending more than the minimum successful query requests.") - f.DurationVar(&cfg.QueryIngestersWithin, "querier.query-ingesters-within", 2*time.Hour, "Maximum lookback beyond which queries are not sent to ingester. 0 means all queries are sent to ingester.") + f.DurationVar(&cfg.QueryIngestersWithin, "querier.query-ingesters-within", 3*time.Hour, "Maximum lookback beyond which queries are not sent to ingester. 0 means all queries are sent to ingester.") f.IntVar(&cfg.MaxConcurrent, "querier.max-concurrent", 10, "The maximum number of concurrent queries.") f.BoolVar(&cfg.QueryStoreOnly, "querier.query-store-only", false, "Queriers should only query the store and not try to query any ingesters") } From 2ec2dfc4febc31f7e77fd5799f86c0c29a124cbf Mon Sep 17 00:00:00 2001 From: Trevor Whitney Date: Mon, 10 Jan 2022 13:01:29 -0700 Subject: [PATCH 06/10] add comment reminder to remove query range config hack Co-authored-by: Owen Diehl --- pkg/loki/loki.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/loki/loki.go b/pkg/loki/loki.go index 39073cedfb573..3251222a07e74 100644 --- a/pkg/loki/loki.go +++ b/pkg/loki/loki.go @@ -136,7 +136,8 @@ func (c *Config) registerServerFlagsWithChangedDefaultValues(fs *flag.FlagSet) { func (c *Config) registerQueryRangeFlagsWithChangedDefaultValues(fs *flag.FlagSet) { throwaway := flag.NewFlagSet("throwaway", flag.PanicOnError) - + // NB: We can remove this after removing Loki's dependency on Cortex and bringing in the queryrange.Config. + // That will let us change the defaults there rather than include wrapper functions like this one. // Register to throwaway flags first. Default values are remembered during registration and cannot be changed, // but we can take values from throwaway flag set and reregister into supplied flags with new default values. c.QueryRange.RegisterFlags(throwaway) From a0e3653ff4fd73839d20412960230baa4b49734d Mon Sep 17 00:00:00 2001 From: Trevor Whitney Date: Mon, 10 Jan 2022 13:06:32 -0700 Subject: [PATCH 07/10] rollback change to align_queries_with_step and parallelise_shardable_queries --- docs/sources/configuration/_index.md | 4 ++-- pkg/loki/loki.go | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/docs/sources/configuration/_index.md b/docs/sources/configuration/_index.md index 5f36c64a099a0..284fa0bbb1056 100644 --- a/docs/sources/configuration/_index.md +++ b/docs/sources/configuration/_index.md @@ -378,7 +378,7 @@ The `query_range` block configures query splitting and caching in the Loki query # Mutate incoming queries to align their start and end with their step. # CLI flag: -querier.align-querier-with-step -[align_queries_with_step: | default = true] +[align_queries_with_step: | default = false] results_cache: # The CLI flags prefix for this block config is: frontend @@ -396,7 +396,7 @@ results_cache: # Perform query parallelisations based on storage sharding configuration and # query ASTs. This feature is supported only by the chunks storage engine. # CLI flag: -querier.parallelise-shardable-queries -[parallelise_shardable_queries: | default = true] +[parallelise_shardable_queries: | default = false] ``` ## ruler diff --git a/pkg/loki/loki.go b/pkg/loki/loki.go index 3251222a07e74..5e146f4981fac 100644 --- a/pkg/loki/loki.go +++ b/pkg/loki/loki.go @@ -147,12 +147,6 @@ func (c *Config) registerQueryRangeFlagsWithChangedDefaultValues(fs *flag.FlagSe switch f.Name { case "querier.split-queries-by-interval": _ = f.Value.Set("30m") - - case "querier.align-querier-with-step": - _ = f.Value.Set("true") - - case "querier.parallelise-shardable-queries": - _ = f.Value.Set("true") } fs.Var(f.Value, f.Name, f.Usage) From cda9112c6d701927da18fa02137b1bd4d39e3774 Mon Sep 17 00:00:00 2001 From: Trevor Whitney Date: Mon, 10 Jan 2022 14:51:58 -0700 Subject: [PATCH 08/10] add upgrading docs --- docs/sources/upgrading/_index.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/docs/sources/upgrading/_index.md b/docs/sources/upgrading/_index.md index 563e8848aa835..e5bbe3d1a950d 100644 --- a/docs/sources/upgrading/_index.md +++ b/docs/sources/upgrading/_index.md @@ -49,6 +49,13 @@ The response body has the following schema: } ``` +#### Changes to default configuration values + +* `split_queries_by_interval` under the Query Range config now defaults to `30m`, it was `0s`. +* `max_chunk_age` for the Ingester now defaults to `2h` instead of `1h`. +* `query_ingesters_within` under the Queier config now defaults to `3h`, it was previously set to 0, meaning always query ingesters. +* `max_concurrent` under the Querier config now defaults to `10` instead of `20`, since is should be the same as the Frontend Worker's `parallelism` setting (which is `10`). + ### Promtail #### `gcplog` labels have changed From 0232fe87baac1c5dbaa4d32eaf0acd467529edb2 Mon Sep 17 00:00:00 2001 From: Trevor Whitney Date: Tue, 11 Jan 2022 11:33:19 -0700 Subject: [PATCH 09/10] re-enable parallelise_shardable_queries by default --- docs/sources/configuration/_index.md | 2 +- pkg/loki/loki.go | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/sources/configuration/_index.md b/docs/sources/configuration/_index.md index 284fa0bbb1056..3689dd678dd32 100644 --- a/docs/sources/configuration/_index.md +++ b/docs/sources/configuration/_index.md @@ -396,7 +396,7 @@ results_cache: # Perform query parallelisations based on storage sharding configuration and # query ASTs. This feature is supported only by the chunks storage engine. # CLI flag: -querier.parallelise-shardable-queries -[parallelise_shardable_queries: | default = false] +[parallelise_shardable_queries: | default = true] ``` ## ruler diff --git a/pkg/loki/loki.go b/pkg/loki/loki.go index 5e146f4981fac..419aa90502081 100644 --- a/pkg/loki/loki.go +++ b/pkg/loki/loki.go @@ -147,6 +147,9 @@ func (c *Config) registerQueryRangeFlagsWithChangedDefaultValues(fs *flag.FlagSe switch f.Name { case "querier.split-queries-by-interval": _ = f.Value.Set("30m") + + case "querier.parallelise-shardable-queries": + _ = f.Value.Set("true") } fs.Var(f.Value, f.Name, f.Usage) From c3db82a578f7658058dd13a8d6a314c45e69511c Mon Sep 17 00:00:00 2001 From: Trevor Whitney Date: Tue, 11 Jan 2022 11:52:10 -0700 Subject: [PATCH 10/10] add parallelise_shardable_queries back to upgrading doc --- docs/sources/upgrading/_index.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/sources/upgrading/_index.md b/docs/sources/upgrading/_index.md index e5bbe3d1a950d..797747e284c56 100644 --- a/docs/sources/upgrading/_index.md +++ b/docs/sources/upgrading/_index.md @@ -51,6 +51,7 @@ The response body has the following schema: #### Changes to default configuration values +* `parallelise_shardable_queries` under the Query Range config now defaults to `true`, it was `false`. * `split_queries_by_interval` under the Query Range config now defaults to `30m`, it was `0s`. * `max_chunk_age` for the Ingester now defaults to `2h` instead of `1h`. * `query_ingesters_within` under the Queier config now defaults to `3h`, it was previously set to 0, meaning always query ingesters.