Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : log_cli Add RFC3339Nano via cli argument for default output #15189

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

steelrain74
Copy link

What this PR does / why we need it:
This PR will address a request to add optional subsecond timings to a logcli command line request. By adding a --timestamp=nanos you will output logs in RFC3339Nano instead of RFC3339 for the default output only.
Which issue(s) this PR fixes:
Fixes #9635

Special notes for your reviewer:
This is not breaking for existing customers as this is an optional flag. The default is still RFC3339

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • [x ] Documentation added
  • [x ] Tests updated
  • [x ] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [ x] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [x ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

steelrain74 and others added 3 commits November 28, 2024 15:11
	modified:   pkg/logcli/output/default.go
	modified:   pkg/logcli/output/output.go
@steelrain74 steelrain74 requested a review from a team as a code owner November 29, 2024 14:24
@CLAassistant
Copy link

CLAassistant commented Nov 29, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support subsecond resolution timestamps in logcli's default output mode
2 participants