Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update _index.md, If the service_name label exists, it's not overwritten #15165

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

cyrille-leclerc
Copy link
Contributor

@cyrille-leclerc cyrille-leclerc commented Nov 27, 2024

If the service_name label exists, it's not overwritten

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

If the `service_name` label exists, it's not overwritten
@cyrille-leclerc cyrille-leclerc requested a review from a team as a code owner November 27, 2024 18:16
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 27, 2024
@trevorwhitney trevorwhitney changed the title Update _index.md: If the service_name label exists, it's not overwritten docs: update _index.md, If the service_name label exists, it's not overwritten Nov 27, 2024
@trevorwhitney trevorwhitney merged commit 6ed336c into main Nov 27, 2024
61 checks passed
@trevorwhitney trevorwhitney deleted the cyrille-leclerc-patch-1 branch November 27, 2024 21:04
loki-gh-app bot pushed a commit that referenced this pull request Nov 27, 2024
loki-gh-app bot pushed a commit that referenced this pull request Nov 27, 2024
loki-gh-app bot pushed a commit that referenced this pull request Nov 27, 2024
loki-gh-app bot pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x backport release-3.3.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants