fix(logql): updated JSONExpressionParser not to unescape extracted values if it is JSON object. #14499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues if it is JSON object. re: #14166 Signed-off-by: Vladyslav Diachenko <[email protected]>
vlad-diachenko
added
type/bug
loki-gh-app bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
…lues if it is JSON object. (#14499) Signed-off-by: Vladyslav Diachenko <[email protected]> (cherry picked from commit 08b1a90)
6 tasks
loki-gh-app bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
…lues if it is JSON object. (#14499) Signed-off-by: Vladyslav Diachenko <[email protected]> (cherry picked from commit 08b1a90)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
updated JSONExpressionParser not to unescape extracted values if it is a JSON object.
re: #9410
Which issue(s) this PR fixes:
Fixes #14166
Special notes for your reviewer:
Execution plan before:
And execution plan after:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR