feat: add backoff mechanism to the retention process #14182
Merged
+120
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
vlad-diachenko
force-pushed
the
vlad.diachenko/add-backoff-config-to-retention
branch
2 times, most recently
from
4542749
to
a3cb045
Compare
…ntion Signed-off-by: Vladyslav Diachenko <[email protected]>
vlad-diachenko
force-pushed
the
vlad.diachenko/add-backoff-config-to-retention
branch
from
a3cb045
to
3f3ccd1
Compare
benclive
approved these changes
Sep 19, 2024
vlad-diachenko
deleted the
vlad.diachenko/add-backoff-config-to-retention
branch
loki-gh-app bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: Vladyslav Diachenko <[email protected]> (cherry picked from commit 3136880)
loki-gh-app bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: Vladyslav Diachenko <[email protected]> (cherry picked from commit 3136880)
This was referenced Sep 19, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
added backoff mechanism to slow down and retry delete requests on retention.
It should help avoid the case when the cloud provider rate limits the compactor due to the huge number of requests fired to delete the chunks.