chore: [k212] fix: special case the return values from a sharded first/last_over_time query #13667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me query (#13578) Signed-off-by: Callum Styan <[email protected]> (cherry picked from commit 29a37d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 29a37d5 from #13578
We noticed during the rollout of
first/last_over_timesharding earlier this week that instant queries would return vectors only (as intended), and the code for handling merging of shardedfirst/last_over_timequeries expected to only receive matrices.With this PR we're special casing the return value from
JoinSampleVectorif the operation type is the shardedfirst/last_over_time.