Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k209] fix(gateway client): exit with nil pointer dereference panic when using ring mode #13460

Merged
merged 1 commit into from
Jul 9, 2024
Merged

chore: [k209] fix(gateway client): exit with nil pointer dereference panic when using ring mode #13460

merged 1 commit into from
Jul 9, 2024

Commits on Jul 9, 2024

  1. fix(gateway client): Fix nil pointer dereference panic when using rul… 

    …er in ring mode (#13436)

Fixes gateway client return with nil pointer panic when using ring mode for ruler service.

`clients.dnsProvider` will only be init when using `simple mode` here: https://github.com/grafana/loki/blob/183406570411a5ad5ceaf32bf07451b8fce608c1/pkg/indexgateway/client.go#L184

Service like `ruler` using `ring mode`  will run into panic `nil pointer reference` during restarting or exiting:

(cherry picked from commit 304db10)
    @littlepangdi @grafana-delivery-bot
    littlepangdi authored and grafana-delivery-bot[bot] committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    190025a View commit details
    Browse the repository at this point in the history