Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Promtail Docker config example seem out of date with the docs #1593

Closed
aocenas opened this issue Jan 28, 2020 · 1 comment · Fixed by #1602
Closed

Docs: Promtail Docker config example seem out of date with the docs #1593

aocenas opened this issue Jan 28, 2020 · 1 comment · Fixed by #1602

Comments

@aocenas
Copy link
Member

aocenas commented Jan 28, 2020

Describe the bug
In docs example section there are parts:

pipeline_stages:
   - docker:

but docker does not seem to be a valid option for the pipeline_stages. I would expect kubernetes_sd_config there.

To Reproduce

Expected behavior

Environment:

Screenshots, Promtail config, or terminal output

@slim-bean
Copy link
Collaborator

hey @aocenas I agree that example is confusing and misleading. The config is technically valid if you had docker writing logs into /var/log but this is very OS dependent and we really recommend the docker logging driver instead.

docker is a valid pipeline_stage but was not documented which is also not very helpful.

I opened #1602 to hopefully address the problems you encountered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants