chore!: Remove wget
from Promtail docker image (backport release-3.3.x)
#15146
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2eea546 from #15101
What this PR does / why we need it:
The package has been added to the Docker image with PR #11711 with the intention to support the Docker healthcheck.
However, to reduce the attack surface of our Docker images, we want to keep them as slim as possible. The current version of Promtail (3.3.0) for example contains a wget version with vulnerability CVE-2024-38428.
The healthcheck can be achieved by other means, e.g.
grafana/promtail
base image and addwget
usingapt install wget
Add wget to promtail Docker image #11590 (comment)
/dev/tcp/127.0.0.1:9080
to establish a connection and check the exit codeAdd wget to promtail Docker image #11590 (comment)
Special notes for your reviewer:
Original discussion about adding wget #11590
This may break someone's Docker compose installation, when they require on the
wget
powered health check.Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR