Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blooms): Only write key and key=value to blooms #14686

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat(blooms): Only write key and key=value to blooms #14686

merged 2 commits into from
Oct 31, 2024

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Oct 31, 2024 •
edited
Loading

What this PR does / why we need it:

We can avoid adding the plain value of a structured metadata field to the blooms.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts changed the title feat(blooms): Only write key=value to blooms feat(blooms): Only write key and key=value to blooms Oct 31, 2024
@salvacorts salvacorts force-pushed the salvacorts/only-write-combined-bloom branch from 5767634 to e2d9bc9 Compare October 31, 2024 15:22
@salvacorts salvacorts marked this pull request as ready for review October 31, 2024 15:29
@salvacorts salvacorts requested a review from a team as a code owner October 31, 2024 15:29
rfratto
rfratto approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating the part of the docs that mentions hashing the value: https://grafana.com/docs/loki/next/operations/bloom-filters/#building-blooms

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 31, 2024
@salvacorts salvacorts merged commit 3af0004 into main Oct 31, 2024
60 checks passed
@salvacorts salvacorts deleted the salvacorts/only-write-combined-bloom branch October 31, 2024 15:40
chaudum pushed a commit that referenced this pull request Nov 6, 2024
@salvacorts @chaudum
feat(blooms): Only write key and key=value to blooms (#14686)
fcdd85e
chaudum pushed a commit that referenced this pull request Nov 7, 2024
@salvacorts @chaudum
feat(blooms): Only write key and key=value to blooms (#14686)
7ff99f4
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salvacorts @rfratto