Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTLP Endpoint] Add deployment.environment.name to the list of promoted resource attributes #14658

Closed
cyrille-leclerc opened this issue Oct 30, 2024 · 1 comment · Fixed by #14747
Labels
OTEL/OLTP type/feature Something new we should do

Comments

@cyrille-leclerc
Copy link
Contributor

cyrille-leclerc commented Oct 30, 2024

Is your feature request related to a problem? Please describe.

OpenTelemetry semantic convention renamed the deployment.environment resource attribute into deployment.environment.name (here) and the Loki OTLP endpoint is only promoting deployment.environment as logstream label, creating a feature gap for users embracing the new attribute name.

Describe the solution you'd like

The Loki OTLP endpoint could by default promote as logstream label the new resource attribute deployment.environment.name in addition to the already promoted deployment.environment to help users migrate.

Note that we probably don't want to do renaming during the ingestion and help users migrating to just one name as such a schema normalization capability is not in place in any of Loki, Mimir, Tempo, or Pyroscope components today.

Describe alternatives you've considered

Don't change the default behaviour, let users encounter regressions as they adopt the new resource attribute name and figure out themselves the solution: edit the Loki config file for self managed users and open a support ticket for Grafana Cloud users.

Additional context
Add any other context or screenshots about the feature request here.

cc @sandeepsukhani and @vlad-diachenko for Loki, cc @aknuds1 and @jesusvazquez who are rolling out a similar resource attribute promotion feature in for Prometheus & Mimir.

@jesusvazquez
Copy link
Member

I've made sure to record this as well in our design doc to do this in Mimir https://docs.google.com/document/d/1tVeuVvt4A_Y9bDUqivngnmFnXSA06ge9wONbvfMz5PQ/edit?tab=t.0 thanks @cyrille-leclerc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTEL/OLTP type/feature Something new we should do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants