Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mixins): retention dashboards fix metric name #14617

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(mixins): retention dashboards fix metric name #14617

merged 1 commit into from
Oct 28, 2024

Conversation

JoaoBraveCoding
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding commented Oct 25, 2024 •
edited by mwimpelberg28
Loading

What this PR does / why we need it:

metric was changed in #11604

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@JoaoBraveCoding JoaoBraveCoding requested a review from a team as a code owner October 25, 2024 10:39
@JoaoBraveCoding JoaoBraveCoding changed the title fix: in retention dashboards fix metric name fix(mixins): retention dashboards fix metric name Oct 25, 2024
ashwanthgoli
ashwanthgoli approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli merged commit c762b9b into grafana:main Oct 28, 2024
62 checks passed
@JoaoBraveCoding JoaoBraveCoding deleted the fix-retenttion-dashboard branch November 8, 2024 11:37
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwanthgoli ashwanthgoli ashwanthgoli approved these changes

@periklis periklis periklis approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoaoBraveCoding @periklis @ashwanthgoli