fix(s3): disable client retries when congestion control is enabled #14588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwanthgoli
changed the title
github-actions
bot
added
the
type/docs
trevorwhitney
approved these changes
Oct 23, 2024
| @@ -295,7 +295,7 @@ type Config struct { | |||
| DisableBroadIndexQueries bool `yaml:"disable_broad_index_queries"` | |||
| MaxParallelGetChunk int `yaml:"max_parallel_get_chunk"` | |||
|
|
|||
| UseThanosObjstore bool `yaml:"use_thanos_objstore" doc:"hidden` | |||
| UseThanosObjstore bool `yaml:"use_thanos_objstore" doc:"hidden"` | |||
There was a problem hiding this comment.
I'm confused how this is related?
There was a problem hiding this comment.
it's not, my editor corrected the incorrect tag
There was a problem hiding this comment.
i think i'll keep this change here instead of raising another pr for this small correction :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With congestion control enabled, we want the cc controller to handle all retries. It is necessary to disable retries performed by the object client.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR