Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka): Set namespace for Loki kafka metrics #14426

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Oct 8, 2024

What this PR does / why we need it:

Sets metric namespace to "loki" and adds the "distributor_" prefix to all the metrics generated by Kafka.

  • These currently show up as "_kafka_..." and "kafka_..." in prometheus
  • I considered setting the "distributor" prefix in the registerer but we have some metrics that are missing this prefix (stream_sharding_count), but have been released for a long time so it would likely break some dashboards/alerts to change it now.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@benclive benclive requested a review from a team as a code owner October 8, 2024 13:56
@benclive benclive merged commit 8aa8a2b into main Oct 8, 2024
62 checks passed
@benclive benclive deleted the fix-metric-names-for-kafka branch October 8, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants