Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): updated helm diff rendering workflow #14424

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

vlad-diachenko
Copy link
Contributor

What this PR does / why we need it:

updated helm diff rendering workflow to render scenarios from BASE branch if PRs branch does not have any scenarios. It should fix the CI on outdated PRs.

…m BASE branch if PRs branch does not have any scenarios. It should fix the CI on outdated PRs.

Signed-off-by: Vladyslav Diachenko <[email protected]>
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vlad!

.github/workflows/helm-loki-ci.yml Outdated Show resolved Hide resolved
@vlad-diachenko vlad-diachenko merged commit 916e511 into main Oct 10, 2024
60 checks passed
@vlad-diachenko vlad-diachenko deleted the vlad.diachenko/helm-diff-workflow-fix branch October 10, 2024 15:27
trevorwhitney added a commit that referenced this pull request Oct 10, 2024
Signed-off-by: Vladyslav Diachenko <[email protected]>
Co-authored-by: Trevor Whitney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants