feat: add query user and query source to "executing query" log lines #14320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <[email protected]>
cstyan
force-pushed
the
callum-executing-info
branch
from
04888bf to
72a2a19
Compare
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
|
Hello @cstyan!
Please, if the current pull request addresses a bug fix, label it with the |
cstyan
added
type/bug
loki-gh-app bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…14320) Signed-off-by: Callum Styan <[email protected]> (cherry picked from commit 4d69929)
jeschkies
pushed a commit
to jeschkies/loki
that referenced
this pull request
Oct 1, 2024
…rafana#14320) Signed-off-by: Callum Styan <[email protected]>
|
@cstyan @trevorwhitney Is there something that needs to be done to enable the user information from Grafana to show up in these logs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a lot of metadata type info. about a query to
QueryTagsheader but don't log much of it theexecuting querylogs. At the very least, pulling out the Grafana username and query source (alert, explore app, etc.) would be useful to determine the source of increased incoming query requests.