-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): update chart with loki version 3.2.0 #14281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your review! we'll need to release a new version with this, we can't leave it pointing to an already released version
@DylanGuedes is this good to go? |
Is the CI failure an issue with forks not having access to GitHub Action secrets? |
sorry, it is/was, but because we recently changed how our CI does the package publishing, we'll need you to rebase one more time and to also update the version from 6.16.0 to 6.17.0 (we had to do a release in between and we preferred it to be before using loki 3.2.0 for stability reasons) |
hey I believe this lint step keeps breaking because rebasing isn't updating your branch code to receive the changes since they're for a different folder. |
Updated the workflow, but still failing. My guess is that this relates to access to secrets from forks. |
Co-authored-by: Dylan Guedes <[email protected]> Co-authored-by: Trevor Whitney <[email protected]>
@trevorwhitney any reason why I can not find this version up on Artifacthub? https://artifacthub.io/packages/helm/grafana/loki |
Co-authored-by: Dylan Guedes <[email protected]> Co-authored-by: Trevor Whitney <[email protected]>
@Starefossen we had an issue with our release automation, you should be able to find version |
Thanks for fixing it! |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR