feat: Introduce new ObjectExistsWithSize API to
#14268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul1r
approved these changes
Sep 25, 2024
LashaJini
pushed a commit
to LashaJini/loki
that referenced
this pull request
Sep 26, 2024
**What this PR does / why we need it**: Introduce a new `ObjectExistsWithSize` API to our object storage interface. This is the same as `ObjectExists` but with the object size as part of the return value. This is useful to compare the object size present.
JoaoBraveCoding
added a commit
to JoaoBraveCoding/loki
that referenced
this pull request
Sep 30, 2024
new method was added in grafana#14268
JoaoBraveCoding
added a commit
to JoaoBraveCoding/loki
that referenced
this pull request
Sep 30, 2024
new method was added in grafana#14268
JoaoBraveCoding
added a commit
to JoaoBraveCoding/loki
that referenced
this pull request
Sep 30, 2024
new method was added in grafana#14268
jeschkies
pushed a commit
to jeschkies/loki
that referenced
this pull request
Oct 1, 2024
**What this PR does / why we need it**: Introduce a new `ObjectExistsWithSize` API to our object storage interface. This is the same as `ObjectExists` but with the object size as part of the return value. This is useful to compare the object size present.
JoaoBraveCoding
added a commit
to JoaoBraveCoding/loki
that referenced
this pull request
Oct 4, 2024
new method was added in grafana#14268
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduce a new
ObjectExistsWithSizeAPI to our object storage interface.This is the same as
ObjectExistsbut with the object size as part of the return value. This is useful to compare the object size present.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR