feat: move detected field logic to query frontend #14212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit 4d9af56 Author: Trevor Whitney <[email protected]> Date: Fri Sep 20 16:38:03 2024 -0600 feat: move detected fields logic to QF commit a23ea8b Author: Trevor Whitney <[email protected]> Date: Fri Sep 20 14:37:35 2024 -0600 fix: enforce query timeouts and limits commit 2ef80ec Author: Trevor Whitney <[email protected]> Date: Fri Sep 20 13:24:35 2024 -0600 chore: no retries for detected_fields commit c7a471d Author: Trevor Whitney <[email protected]> Date: Fri Sep 20 13:05:33 2024 -0600 feat: return empty result instead of error for failed detected fields queries commit 7b3529a Author: Trevor Whitney <[email protected]> Date: Fri Sep 20 09:39:33 2024 -0600 fix: guard against failed ingester requests for detected fields (cherry picked from commit fbf9018)
7 tasks
trevorwhitney
commented
Sep 23, 2024
| @@ -1134,33 +1135,6 @@ func (q *SingleTenantQuerier) DetectedFields(ctx context.Context, req *logproto. | |||
| }, nil | |||
| } | |||
|
|
|||
| func getParsersFromExpr(expr syntax.LogSelectorExpr) []string { | |||
There was a problem hiding this comment.
this wasn't used by anything
|
this is great! have a few comments.. thank you! |
|
This PR must be merged before a backport PR will be created. |
2 similar comments
|
This PR must be merged before a backport PR will be created. |
|
This PR must be merged before a backport PR will be created. |
loki-gh-app bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit 36ace66)
7 tasks
loki-gh-app bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit 36ace66)
7 tasks
jeschkies
pushed a commit
to jeschkies/loki
that referenced
this pull request
Oct 1, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
/detected_fieldsqueries in ops are failing over bigger time ranges in Explore Logs, whereas logs queries for the same time period are not. I think this is because of all the optimizations/protections we have in place for logs queries (result cache, sharding, limits, etc.) that have not been implemented for/detected_fields. However, since/detected_fieldsis just doing aSelectLogsunder the hood in the querier, if we move the detected fields logic up to the Query Frontend we can use the existing limited and filter tripperwares to get the underlying logs. Due to the limits already in place in those tripperwares, they will never return too many lines for the detected fields logic to reasonably handle in the Query Frontend, which allows us to move this logic there without fear of knocking over QFs.This replaces #14210 as it works much better. I have tested in in Ops and it solves the problem without overloading QFs.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR