Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): add missing loki.storage.azure.chunkDelimiter parameter to Helm chart #14011

Merged
merged 13 commits into from
Oct 3, 2024

Conversation

NGPixel
Copy link
Contributor

@NGPixel NGPixel commented Aug 30, 2024

What this PR does / why we need it:

The helm chart is missing the chunk_delimiter parameter for Azure storage. This PR adds it to the values as chunkDelimiter.

Which issue(s) this PR fixes:
Fixes #14010

Special notes for your reviewer:
N/A

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@NGPixel NGPixel requested a review from a team as a code owner August 30, 2024 01:49
@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Aug 30, 2024
@NGPixel NGPixel changed the title fix: add missing loki.storage.azure.chunkDelimiter parameter to Helm chart fix(helm): add missing loki.storage.azure.chunkDelimiter parameter to Helm chart Aug 30, 2024
Copy link
Contributor

@vlad-diachenko vlad-diachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 thanks @NGPixel

@vlad-diachenko vlad-diachenko self-assigned this Sep 10, 2024
@vlad-diachenko
Copy link
Contributor

@NGPixel could you please fix the CI and bump the version in chart.yaml, add an entry to the changelog, and regenerate the docs.

@NGPixel
Copy link
Contributor Author

NGPixel commented Sep 11, 2024

@vlad-diachenko It should be fixed now.

@NGPixel
Copy link
Contributor Author

NGPixel commented Sep 20, 2024

@vlad-diachenko Any updates?

@trevorwhitney
Copy link
Collaborator

@NGPixel sorry this fell through the cracks. Any chance you can resolve the conflicts today, I'm happy to shepard it through.

@NGPixel
Copy link
Contributor Author

NGPixel commented Sep 28, 2024

Thanks @trevorwhitney, I updated the files against the latest version.

@NGPixel
Copy link
Contributor Author

NGPixel commented Sep 30, 2024

Can @trevorwhitney or @vlad-diachenko merge this PR before anything else comes up? I've had to update the PR 3 times already because the version keeps incrementing. Why is the version numbering not automatically calculated during release (like almost any other software) instead of manually inside the PR itself?? This is wasting a lot of time on the contributors and getting quite ridiculous.

@trevorwhitney
Copy link
Collaborator

@NGPixel I agree. We have changed the helm release process to not cut a release and bump the version on every merged PR

@trevorwhitney trevorwhitney merged commit 08c70cc into grafana:main Oct 3, 2024
64 checks passed
@NGPixel NGPixel deleted the patch-1 branch October 5, 2024 21:13
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing chunkDelimiter parameter for Azure storage in Helm chart
4 participants