Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Propagate query stats from quantile & topk queries #13831

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Aug 9, 2024

What this PR does / why we need it:

  • Fixes query stats propagation from queriers after sharding/splitting for two newer query paths: TopKSketchesResponse and QuantileSketchResponse.
  • This means the query-frontend will show correct stats for the work completed executing a query.

@benclive benclive requested a review from a team as a code owner August 9, 2024 09:55
@benclive benclive requested a review from cstyan August 9, 2024 10:31
@cstyan cstyan force-pushed the fix-stats-propagation-for-topk-and-quantile branch from a644a40 to de68680 Compare September 16, 2024 17:18
@pull-request-size pull-request-size bot added size/S and removed size/M labels Sep 16, 2024
@benclive benclive merged commit 78b275b into main Sep 17, 2024
61 checks passed
@benclive benclive deleted the fix-stats-propagation-for-topk-and-quantile branch September 17, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants