Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix a bug where AppendRequest with no entries triggers flush #13672

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Jul 26, 2024

What this PR does / why we need it:

This commit fixes a bug where an AppendRequest with no entries triggers a flush. This is because the code expects a successful Append to SegmentWriter to set the firstAppend timestamp. This is an alternative fix to #13665.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

This commit fixes a bug where an AppendRequest with no entries
triggers a flush. This is because the code expects a successful
Append to SegmentWriter to set the firstAppend timestamp.
@grobinson-grafana grobinson-grafana self-assigned this Jul 26, 2024
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner July 26, 2024 08:57
Copy link
Contributor

@benclive benclive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is much cleaner I think

@grobinson-grafana grobinson-grafana merged commit 8a3ae22 into main Jul 26, 2024
62 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/fix-append-no-entries-2 branch July 26, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants